Repository navigation
test(render-foundation): data-URI SVG 解码验证 - #143
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: a4ab85d1-89a5-407c-b898-95156f6e7038) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Removing
BudgetedRenderSession::newin page-load budget rendering can panic at runtime; the dispatch-by-magic test may no longer execute.Overview
Adds a render-foundation unit test that decodes a URL-encoded
data:image/svg+xml… URI viadecode_data_uriand checks the SVG rasterizes to a non-zero bitmap (bing-t5 / CSSbackground-imagedata-URI path).The existing magic-byte dispatch test is renamed to
test_decode_image_bytes_dispatches_by_magicand is no longer marked#[test], so it may stop running; the new SVG data-URI test has a duplicate#[test]attribute.In webview
advance_render, the line that createdBudgetedRenderSession::new(html, css_for_render)aftersubstitute_css_vars_textwas removed, while the code stillexpects a session—likely an accidental regression unless session creation moved elsewhere.Reviewed by Cursor Bugbot for commit 3ed4223. Bugbot is set up for automated code reviews on this repo. Configure here.